-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move some string helper functions to the worker-thread #15701
Move some string helper functions to the worker-thread #15701
Conversation
…functions Given that these functions are virtually identical, with the latter only adding a BOM, we can combine the two. Furthermore, since both functions were only used on the worker-thread, there's no reason to duplicate this functionality in both of the `pdf.js` and `pdf.worker.js` files.
Given that this helper function is only used on the worker-thread, there's no reason to duplicate it in both of the `pdf.js` and `pdf.worker.js` files.
Given that this helper function is only used on the worker-thread, there's no reason to duplicate it in both of the `pdf.js` and `pdf.worker.js` files.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/df613ffff7b206b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a7a200245e21c6d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/df613ffff7b206b/output.txt Total script time: 25.45 mins
Image differences available at: http://54.241.84.105:8877/df613ffff7b206b/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a7a200245e21c6d/output.txt Total script time: 33.34 mins
Image differences available at: http://54.193.163.58:8877/a7a200245e21c6d/reftest-analyzer.html#web=eq.log |
Looks good. Thank you for doing this (and adding some extra tests)! |
Please refer to the individual commit messages for additional details.