Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unit test coverage of src/core/core_utils.js #15905

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Improve unit test coverage of src/core/core_utils.js #15905

merged 2 commits into from
Jan 14, 2023

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Jan 8, 2023 •
edited
Loading

This patch introduces unit tests for the recoverJsURL and numberToString core utility functions that were missing before, increasing the overall unit test coverage of this file.

@timvandermeij timvandermeij changed the title Improve unit test coverage of the src/core/core_utils.js Improve unit test coverage of src/core/core_utils.js Jan 8, 2023
@timvandermeij
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

pdfjsbot commented Jan 8, 2023

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fdf8eda5f1adada/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 8, 2023

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bffd221afa9c139/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jan 8, 2023

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/fdf8eda5f1adada/output.txt

Total script time: 2.36 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jan 8, 2023

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bffd221afa9c139/output.txt

Total script time: 14.19 mins

  • Unit Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Jan 8, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed, since more unit-tests is always a good idea; thank you!

test/unit/core_utils_spec.js Outdated Show resolved Hide resolved
@timvandermeij
Copy link
Contributor Author

/botio unittest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/517086b800e586b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4869a341c754ab2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/517086b800e586b/output.txt

Total script time: 2.33 mins

  • Unit Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/4869a341c754ab2/output.txt

Total script time: 11.75 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 517d7a6 into mozilla:master Jan 14, 2023
@timvandermeij timvandermeij deleted the core-utils-unit-tests branch January 14, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
core test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timvandermeij @pdfjsbot @Snuffleupagus