Try to avoid to interpret wheel events as pinch-to-zoom ones (bug 1810800) #15957
Conversation
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e6a89334c823d22/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/e6a89334c823d22/output.txt Total script time: 1.50 mins Published |
There was a problem hiding this comment.
r=me, since this seems to work in my testing when using mouse-wheel zooming on Windows.
However, it really doesn't feel great having to jump through these kind of hoops and there's probably going to be some configuration where it still doesn't work correctly.
I wonder what our chances are of getting e.g. Firefox to add a property to the WheelEvent that would let us detect this particular case directly?
Yep it's why it's far from perfect.
Yes it's exactly what I've in mind :). |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ece3cbe8eb78f18/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6590865d8ffaa21/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6590865d8ffaa21/output.txt Total script time: 4.39 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ece3cbe8eb78f18/output.txt Total script time: 15.92 mins
|
The solution here is likely far from perfect but as far as I can tell it works "correctly" on linux/mac/windows.
With Firefox, we've potentially a bug on laptops when the pref
mousewheel.with_control.actionis set to 1 (which means that we want to scroll even if ctrl is pressed). So we should hack on Firefox to find a satisfying solution but as said it's probably the best we can do.