Fix various zooming regressions (PR 15812 follow-up) #16227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `zoomLayer` isn't rotated correctly in all cases. To reproduce: - Load https://github.com/mozilla/pdf.js/files/1522715/wuppertal_2012.pdf - Let the document render. - Rotate the document *four* times, such that the original rotation is restored. The easiest solution, as far as I can tell, is that we always set the `transform` just as we did (for years) prior to the changes in PR 15812.
Currently if you e.g. enable the `useOnlyCssZoom` option rendering may no longer finish as intended. To reproduce: - Enable the `useOnlyCssZoom` option. - Load https://github.com/mozilla/pdf.js/files/1522715/wuppertal_2012.pdf (in the development viewer). - When rendering starts, *immediately* change the zoom-level. In this case the document will never finish rendering, since the `postponeDrawing`-functionality will (here incorrectly) abort rendering and with CSS-only zooming rendering is only expected to happen once per page. To fix this we'll simply ignore any `drawingDelay` when CSS-only zooming is used (regardless if it's triggered via the option or the zoom-level being very large).
Snuffleupagus
added
viewer
regression
release-blocker
Snuffleupagus
changed the title
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0d8fabed06ef935/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/aa37e4fc35b265e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0d8fabed06ef935/output.txt Total script time: 4.38 mins
|
calixteman
reviewed
Mar 29, 2023
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/aa37e4fc35b265e/output.txt Total script time: 17.00 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix rotation of the
zoomLayer(PR 15812 follow-up)Currently the
zoomLayerisn't rotated correctly in all cases. To reproduce:The easiest solution, as far as I can tell, is that we always set the
transformjust as we did (for years) prior to the changes in PR Only redraw after zooming is finished (bug 1661253) #15812.Fix CSS-only zooming in the viewer (PR 15812 follow-up)
Currently if you e.g. enable the
useOnlyCssZoomoption rendering may no longer finish as intended. To reproduce:useOnlyCssZoomoption.In this case the document will never finish rendering, since the
postponeDrawing-functionality will (here incorrectly) abort rendering and with CSS-only zooming rendering is only expected to happen once per page.To fix this we'll simply ignore any
drawingDelaywhen CSS-only zooming is used (regardless if it's triggered via the option or the zoom-level being very large).