-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to also cache images at the "page"-level (issue 16263) #16268
Attempt to also cache images at the "page"-level (issue 16263) #16268
Conversation
Currently we have two separate image-caches on the worker-thread: - A local one, which is unique to each `PartialEvaluator.getOperatorList` invocation. This one caches both names *and* references, since image-resources may be accessed in either way. - A global one, which applies to the entire PDF documents and all its pages. This one only caches references, since nothing else would work. This patch introduces a third image-cache, which essentially sits "between" the two existing ones. The new `RegionalImageCache`[1] will be usable throughout a `PartialEvaluator` instance, and consequently it *only* caches references, which thus allows us to keep track of repeated image-resources found in e.g. different /Form and /SMask objects. --- [1] For lack of a better word, since naming things is hard...
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/69da3f42f5e9f40/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d992bf11adccca2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d992bf11adccca2/output.txt Total script time: 26.88 mins
Image differences available at: http://54.241.84.105:8877/d992bf11adccca2/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/69da3f42f5e9f40/output.txt Total script time: 33.45 mins
Image differences available at: http://54.193.163.58:8877/69da3f42f5e9f40/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cf6778889175a46/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6936cb5c851f2d0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6936cb5c851f2d0/output.txt Total script time: 22.35 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cf6778889175a46/output.txt Total script time: 23.57 mins
|
Currently we have two separate image-caches on the worker-thread:
PartialEvaluator.getOperatorList
invocation. This one caches both names and references, since image-resources may be accessed in either way.This patch introduces a third image-cache, which essentially sits "between" the two existing ones. The new
RegionalImageCache
[1] will be usable throughout aPartialEvaluator
instance, and consequently it only caches references, which thus allows us to keep track of repeated image-resources found in e.g. different /Form and /SMask objects.[1] For lack of a better word, since naming things is hard...