Slightly modernize print-related code #16288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By getting the width/height of the first page initially, we can slightly reduce the amount of code needed both in the `hasEqualPageSizes`-check and when building the print-styles.
…sses Note that both of the affected files are old enough to predate the general availability of `class`.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c3080fa119c02c1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ad3ba27c59a4b0d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c3080fa119c02c1/output.txt Total script time: 4.71 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ad3ba27c59a4b0d/output.txt Total script time: 12.65 mins
|
timvandermeij
approved these changes
Apr 15, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly modernize the print
layout-methodsBy getting the width/height of the first page initially, we can slightly reduce the amount of code needed both in the
hasEqualPageSizes-check and when building the print-styles.Convert
FirefoxPrintServiceandPDFPrintServiceinto standard classesNote that both of the affected files are old enough to predate the general availability of
class.