Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the PDFSidebar.#forceRendering method #16379

Merged
merged 1 commit into from
May 4, 2023
Merged

Simplify the PDFSidebar.#forceRendering method #16379

merged 1 commit into from
May 4, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

The fallback code-path has never really been used, since the PDFSidebar is only used in the default viewer (and has never been exposed in e.g. the COMPONENTS-build).

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2023

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2e94724a0efabb5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented May 2, 2023

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2e94724a0efabb5/output.txt

Total script time: 1.27 mins

Published

@Snuffleupagus Snuffleupagus requested a review from calixteman May 3, 2023 07:24
calixteman
calixteman reviewed May 4, 2023
View reviewed changes
web/pdf_sidebar.js Outdated Show resolved Hide resolved
calixteman
calixteman approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Snuffleupagus
Simplify the PDFSidebar.#forceRendering method
9dcc504 
The fallback code-path has never really been used, since the `PDFSidebar` is only used in the default viewer (and has never been exposed in e.g. the COMPONENTS-build).
@Snuffleupagus Snuffleupagus force-pushed the sidebar-forceRendering branch from 5e0b97b to 9dcc504 Compare May 4, 2023 10:52
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7d7571551359a4f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6373bcc64c5632f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7d7571551359a4f/output.txt

Total script time: 4.56 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6373bcc64c5632f/output.txt

Total script time: 14.85 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit 2fab583 into mozilla:master May 4, 2023
@Snuffleupagus Snuffleupagus deleted the sidebar-forceRendering branch May 4, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @pdfjsbot @moz-tools-bot @calixteman