-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply HCM filters on annotations which have their own canvas (bug 1830850) #16380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests; thank you!
/botio test |
Still the same error (rate limit). |
148e762
to
c07149a
Compare
Given the problems with the bots, and the relatively small size of this patch (with the functionality being limited to annotations), I've just tested this locally on Windows 11; with the exception of the "usual" intermittent failures this seems to work just fine. @calixteman If you've also successfully tested this locally, please feel free to land this patch without waiting for the bots to start working again! |
I tried with my own account but I didn't a way to have the write permission (to add a comment) for this repo. |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/822792b5c4dcf7c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/ef5370d54f7d743/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/ef5370d54f7d743/output.txt Total script time: 27.60 mins
Image differences available at: http://54.241.84.105:8877/ef5370d54f7d743/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/822792b5c4dcf7c/output.txt Total script time: 32.93 mins
Image differences available at: http://54.193.163.58:8877/822792b5c4dcf7c/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7b850b1e9deffc3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/527f6f8c4a9f502/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/527f6f8c4a9f502/output.txt Total script time: 22.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/7b850b1e9deffc3/output.txt Total script time: 23.76 mins
|
No description provided.