Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of canvas::rescaleAndStroke by around 30% (bug 1135277) #16448

Merged
merged 1 commit into from
May 20, 2023

Conversation

calixteman
Copy link
Contributor

The pdf linked in bug 1135277 contains a lot of stroke instructions. In using the Firefox profiler, this patch helps to reduce the overall spent time in this function by 30%.

The pdf linked in bug 1135277 contains a lot of stroke instructions.
In using the Firefox profiler, this patch helps to reduce the overall
spent time in this function by 30%.
@calixteman calixteman requested a review from Snuffleupagus May 20, 2023 16:34
@marco-c marco-c changed the title Improve performance of canvas::rescaleAndStroke by around 30% Improve performance of canvas::rescaleAndStroke by around 30% (bug 1135277) May 20, 2023
@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/91f1a4271140f9b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/91f1a4271140f9b/output.txt

Total script time: 1.31 mins

Published

@Snuffleupagus
Copy link
Collaborator

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2b5453bf6e1396f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6f5fa58ab77ccdd/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/2b5453bf6e1396f/output.txt

Total script time: 27.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 26
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/2b5453bf6e1396f/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/6f5fa58ab77ccdd/output.txt

Total script time: 34.43 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 26

Image differences available at: http://54.193.163.58:8877/6f5fa58ab77ccdd/reftest-analyzer.html#web=eq.log

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on some quick testing, using pdfBug=Stats locally on Windows, this seems to reduce the rendering time of the entire PDF document by about 15% (so these methods must be really hot in this case).

r=me, thank you!

@calixteman calixteman merged commit 65e2343 into mozilla:master May 20, 2023
@calixteman calixteman deleted the improve_rescaleandstroke branch May 20, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants