-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve performance of canvas::rescaleAndStroke by around 30% (bug 1135277) #16448
Improve performance of canvas::rescaleAndStroke by around 30% (bug 1135277) #16448
Conversation
The pdf linked in bug 1135277 contains a lot of stroke instructions. In using the Firefox profiler, this patch helps to reduce the overall spent time in this function by 30%.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/91f1a4271140f9b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/91f1a4271140f9b/output.txt Total script time: 1.31 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2b5453bf6e1396f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6f5fa58ab77ccdd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2b5453bf6e1396f/output.txt Total script time: 27.29 mins
Image differences available at: http://54.241.84.105:8877/2b5453bf6e1396f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6f5fa58ab77ccdd/output.txt Total script time: 34.43 mins
Image differences available at: http://54.193.163.58:8877/6f5fa58ab77ccdd/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on some quick testing, using pdfBug=Stats
locally on Windows, this seems to reduce the rendering time of the entire PDF document by about 15% (so these methods must be really hot in this case).
r=me, thank you!
The pdf linked in bug 1135277 contains a lot of stroke instructions. In using the Firefox profiler, this patch helps to reduce the overall spent time in this function by 30%.