[Editor] Add support for printing/saving newly added Stamp annotations #16588
Conversation
There was a problem hiding this comment.
Adding a few comments/questions based on an initial look.
Given that there's a Firefox, and hopefully also a PDF.js library, release coming in a week I don't believe that we want to land Stamp-editing just prior to that, to allow us more time to test it and iron out any bugs.
Hence why I started with reviewing this patch, since I believe that we'll be able to land this right away (once reviewed/tested) given that it doesn't add any user-visible functionality.
In order to minimize the size the of a saved pdf, we generate only one image and use a reference in each annotation using it. When printing, it's slightly different since we have to render each page independantly but we use the same image within a page.
calixteman
force-pushed
the
editor_stamp_2
branch
from
122eae8 to
599b949
Compare
|
Once #16588 (comment) has been checked, please run all tests. |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2031f48808ca6d8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4d03d7194fed180/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/2031f48808ca6d8/output.txt Total script time: 25.25 mins
Image differences available at: http://54.241.84.105:8877/2031f48808ca6d8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4d03d7194fed180/output.txt Total script time: 38.59 mins
Image differences available at: http://54.193.163.58:8877/4d03d7194fed180/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2a6160c9b552e8d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f257800112b4edc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2a6160c9b552e8d/output.txt Total script time: 20.61 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f257800112b4edc/output.txt Total script time: 25.53 mins
|
In order to minimize the size the of a saved pdf, we generate only one image and use a reference in each annotation using it. When printing, it's slightly different since we have to render each page independantly but we use the same image within a page.