XFA - Set storage values to select and option elements

[TaTo30]

With XFA Forms, select fields always render with default attributes values and doesn't change if storage has different values, this PR intent to fix that by updating element attributes with storage values if exists and removing the 'selected' attribute (if exists) if the option actually isn't selected.

[Snuffleupagus]

I've tagged Calixte for review, however a couple of quick observations:

• The commit message feels a little short and non-descriptive, please keep in mind that all information/context should be included in the commit message as well (and not only in the PR description).
• Please note that all PRs should include test(s) to ensure that things first of all work as intended and secondly won't accidentally break in the future.

[calixteman]

Do you have an example of pdf which demonstrates the issue you're trying to fix ?

[TaTo30]

@Snuffleupagus Thanks for the suggestions.

@calixteman This is the pdf i'm using: xfa_invoice_example.pdf

[TaTo30]

I found this issue when i wanted implement the XFA forms in a web application, so i used the npm package pdfjs-dist and tried to play with transformation features like scaling and rotating, i noticed that all fields keeps the stored value but select didn't do it.

This is the current behavior:

This is the expected behavior (with the changes i made):

[calixteman]

LGTM. Thank you.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c9e32b0b860ba03/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b5e590508e58de8/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/b5e590508e58de8/output.txt

Total script time: 25.25 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 15
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b5e590508e58de8/reftest-analyzer.html#web=eq.log

[Snuffleupagus]

Please see https://github.com/mozilla/pdf.js/wiki/Squashing-Commits and please also improve the commit message as was mentioned previously.

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/c9e32b0b860ba03/output.txt

Total script time: 39.15 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  errors: 1
  different ref/snapshot: 31
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/c9e32b0b860ba03/reftest-analyzer.html#web=eq.log

[TaTo30]

@Snuffleupagus Done!

[Snuffleupagus]

Sorry, but I think that the commit message should mention XFA (as the PR title does) since that's not really clear unless you actually look at the code. (You'd probably guess that it's related to the regular annotationLayer otherwise.)

Please keep in mind that it's very helpful with good/clear commit messages when using the git command-line, such as e.g. during bisecting and other operations.

[TaTo30]

@Snuffleupagus Fixed.

Please keep in mind that it's very helpful with good/clear commit messages when using the git command-line, such as e.g. during bisecting and other operations.

I got it, sorry if i'm kind of newbie using git, all of this are new experiences for me 😅

[Snuffleupagus]

Thanks!