-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Editor] Refactor dragging and dropping an editor (bug 1802895, bug 1844618) #16781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Please fix the draggind
-> dragging
typo in the commit message (and PR title).
8382bee
to
ed2f510
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remember to fix #16781 (review) as well.
r=me, with the comments addressed; thank you!
…618) It'll help to have a full control on what's happening when moving an editor.
ed2f510
to
b59b1a8
Compare
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/dff8521b34ed5d3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/96bdd13b3590de3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/96bdd13b3590de3/output.txt Total script time: 4.93 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/dff8521b34ed5d3/output.txt Total script time: 17.51 mins
|
It'll help to have a full control on what's happening when moving an editor.