Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Refactor dragging and dropping an editor (bug 1802895, bug 1844618) #16781

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

calixteman
Copy link
Contributor

It'll help to have a full control on what's happening when moving an editor.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Please fix the draggind -> dragging typo in the commit message (and PR title).

src/display/editor/editor.js Outdated Show resolved Hide resolved
web/viewer.css Outdated Show resolved Hide resolved
@marco-c marco-c changed the title [Editor] Refactor draggind and dropping an editor (bugs 1802895, 1844618) [Editor] Refactor draggind and dropping an editor (bug 1802895, bug 1844618) Aug 3, 2023
@calixteman calixteman force-pushed the editor_rewrite_dragging branch from 8382bee to ed2f510 Compare August 3, 2023 08:45
@Snuffleupagus Snuffleupagus changed the title [Editor] Refactor draggind and dropping an editor (bug 1802895, bug 1844618) [Editor] Refactor dragging and dropping an editor (bug 1802895, bug 1844618) Aug 3, 2023
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remember to fix #16781 (review) as well.

r=me, with the comments addressed; thank you!

src/display/editor/tools.js Outdated Show resolved Hide resolved
web/pdf_viewer.js Outdated Show resolved Hide resolved
src/display/editor/tools.js Outdated Show resolved Hide resolved
…618)

It'll help to have a full control on what's happening when moving an editor.
@calixteman calixteman force-pushed the editor_rewrite_dragging branch from ed2f510 to b59b1a8 Compare August 3, 2023 12:48
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dff8521b34ed5d3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/96bdd13b3590de3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/96bdd13b3590de3/output.txt

Total script time: 4.93 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/dff8521b34ed5d3/output.txt

Total script time: 17.51 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 3994752 into mozilla:master Aug 3, 2023
@calixteman calixteman deleted the editor_rewrite_dragging branch August 3, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants