Update the StampEditor.isEmpty method to handle File (PR 16828 follow-up)
#16844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow-up) After the changes in PR 16828 the `StampEditor` can now be initialized with a File, in addition to a URL, hence it seems that the `isEmpty` method ought to take that property into account as well. Looking at this I also noticed that the assignment in the constructor may cause the `this.#bitmapUrl`/`this.#bitmapFile` fields be `undefined` which "breaks" the comparisons in the `isEmpty` method. We could obviously fix those specific cases, but it seemed overall safer (with future changes) to just update the `isEmpty` method to be less sensitive to exactly how these fields are initialized and reset.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/268f656c7b27a07/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a65f0a8fdb617eb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a65f0a8fdb617eb/output.txt Total script time: 5.01 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/268f656c7b27a07/output.txt Total script time: 15.96 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the changes in PR #16828 the
StampEditorcan now be initialized with a File, in addition to a URL, hence it seems that theisEmptymethod ought to take that property into account as well.Looking at this I also noticed that the assignment in the constructor may cause the
this.#bitmapUrl/this.#bitmapFilefields beundefinedwhich "breaks" the comparisons in theisEmptymethod.We could obviously fix those specific cases, but it seemed overall safer (with future changes) to just update the
isEmptymethod to be less sensitive to exactly how these fields are initialized and reset.