-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix integration test "FreeText Editor Move several FreeTexts must move several annotations" #16964
Fix integration test "FreeText Editor Move several FreeTexts must move several annotations" #16964
Conversation
… integration test The x/y-coordinates are floats instead of integers like one might expect. The current approach rounds both the old and the new coordinates in order to do integer comparison. However, rounding each coordinate individually causes too much loss of precision because, depending on the decimal value, they are either rounded up or down which causes intermittent off-by-one errors. This commit fixes the problem by comparing coordinate differences instead of the coordinates themselves. The precision loss is avoided by subtracting the old from the new coordinate as-is and only rounding the final result.
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5e33c20834acf8e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5e33c20834acf8e/output.txt Total script time: 4.87 mins
|
/botio-linux integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f615ed24aa24580/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f615ed24aa24580/output.txt Total script time: 4.88 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/59bc2f26a8990da/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/86bd72072bc402b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/59bc2f26a8990da/output.txt Total script time: 5.28 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/86bd72072bc402b/output.txt Total script time: 16.40 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you very much for taking the time to do that.
This is part 2 of the work to create tickets for and on a case-by-case basis fix intermittently failing integration tests.
The commit messages contain more information about the individual changes.
Fixes #16926.