Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test "FreeText Editor Move several FreeTexts must move several annotations" #16964

Merged

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Sep 17, 2023

This is part 2 of the work to create tickets for and on a case-by-case basis fix intermittently failing integration tests.

The commit messages contain more information about the individual changes.

Fixes #16926.

… integration test

The x/y-coordinates are floats instead of integers like one might
expect. The current approach rounds both the old and the new
coordinates in order to do integer comparison. However, rounding each
coordinate individually causes too much loss of precision because,
depending on the decimal value, they are either rounded up or down
which causes intermittent off-by-one errors.

This commit fixes the problem by comparing coordinate differences
instead of the coordinates themselves. The precision loss is avoided
by subtracting the old from the new coordinate as-is and only rounding
the final result.
@timvandermeij
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5e33c20834acf8e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5e33c20834acf8e/output.txt

Total script time: 4.87 mins

  • Integration Tests: Passed

@timvandermeij
Copy link
Contributor Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f615ed24aa24580/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/f615ed24aa24580/output.txt

Total script time: 4.88 mins

  • Integration Tests: Passed

@timvandermeij
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/59bc2f26a8990da/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/86bd72072bc402b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/59bc2f26a8990da/output.txt

Total script time: 5.28 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/86bd72072bc402b/output.txt

Total script time: 16.40 mins

  • Integration Tests: FAILED

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you very much for taking the time to do that.

@timvandermeij timvandermeij merged commit 9781989 into mozilla:master Sep 17, 2023
@timvandermeij timvandermeij deleted the fix-intermittent-annotations-move branch September 17, 2023 15:46
@timvandermeij timvandermeij changed the title Fix off-by-one errors in the "FreeText must move several annotations" integration test Fix integration test "FreeText Editor Move several FreeTexts must move several annotations" Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix integration test "FreeText Editor Move several FreeTexts must move several annotations"
3 participants