[Editor] Avoid to darken the current editor when opening the alt-text dialog

[calixteman]

No description provided.

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4cca63fead500e7/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/4cca63fead500e7/output.txt

Total script time: 1.49 mins

Published

• Viewer: http://54.241.84.105:8877/4cca63fead500e7/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/4cca63fead500e7/legacy/web/viewer.html

[calixteman]

We should disable zooming with the mouse when the dialog is displayed because it leads to some inconsistencies.

[Snuffleupagus]

We should disable zooming with the mouse when the dialog is displayed because it leads to some inconsistencies.

That'd hopefully be as simple as adding e.g. the following code at the appropriate spots in the various wheel/touch event handlers in the web/app.js file:

if (PDFViewerApplication.overlayManager.active) {
  evt.preventDefault();
  return;
}

[Snuffleupagus]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2dabbc852a819d5/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/2dabbc852a819d5/output.txt

Total script time: 1.58 mins

Published

• Viewer: http://54.241.84.105:8877/2dabbc852a819d5/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/2dabbc852a819d5/legacy/web/viewer.html

[Snuffleupagus]

This looks much nicer/better, since it clearly focuses on the active image!

One small question, although I'd guess that it's a wontfix since it's an edge-case that might be annoying to fix in general:
If you add a fairly large image, I used this one, such that the entire image won't fit on screen at once, when opening the altText dialog the mask may also "include" part of the viewer toolbar.

[calixteman]

This looks much nicer/better, since it clearly focuses on the active image!

One small question, although I'd guess that it's a wontfix since it's an edge-case that might be annoying to fix in general: If you add a fairly large image, I used this one, such that the entire image won't fit on screen at once, when opening the altText dialog the mask may also "include" part of the viewer toolbar.

Yep I thought about this case. A way to solve it, would be to take into account only the really visible part of the editor which should be possible but probably more work (we should take into account the toolbar, margins, ...) or maybe there's a smart trick we could use.

[Snuffleupagus]

r=me, this looks great; thank you!