Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timeouts from the copy_paste integration test #17059

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Remove timeouts from the copy_paste integration test #17059

merged 1 commit into from
Oct 3, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman added the test label Oct 2, 2023
@Snuffleupagus
Copy link
Collaborator

I'm assuming that this (fully) fixes issue #16927?
If so, please also address the naming collisions mentioned in #16927 (comment).

@calixteman calixteman force-pushed the fix_copy_paste_integration_test branch from c07ffc7 to b4ebc85 Compare October 3, 2023 09:10
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4db9e734a35d132/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8965caa27718f99/output.txt

Snuffleupagus
Snuffleupagus approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-existing thing, but isn't this line redundant given the explicit check that immediately follows it?

pdf.js/test/integration/copy_paste_spec.js

Line 170 in b4ebc85

expect(!!text).withContext(`In ${browserName}`).toEqual(true);

r=me, thank you!

@Snuffleupagus Snuffleupagus linked an issue Oct 3, 2023 that may be closed by this pull request
Fix integration test "Copy and paste all text must check that we've all the contents on copy/paste" #16927
Closed
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/8965caa27718f99/output.txt

Total script time: 5.81 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/4db9e734a35d132/output.txt

Total script time: 18.02 mins

  • Integration Tests: FAILED

@calixteman calixteman force-pushed the fix_copy_paste_integration_test branch from b4ebc85 to 0549a95 Compare October 3, 2023 09:54
@calixteman calixteman force-pushed the fix_copy_paste_integration_test branch from 0549a95 to bb59f44 Compare October 3, 2023 09:55
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2617208bfe4e2e4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/85fb7024067af32/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/2617208bfe4e2e4/output.txt

Total script time: 5.31 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/85fb7024067af32/output.txt

Total script time: 20.05 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 0cc8c66 into mozilla:master Oct 3, 2023
3 checks passed
@calixteman calixteman deleted the fix_copy_paste_integration_test branch October 3, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix integration test "Copy and paste all text must check that we've all the contents on copy/paste"
3 participants
@calixteman @Snuffleupagus @moz-tools-bot