Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Support resizing editors with the keyboard (bug 1854340) #17062

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[Editor] Support resizing editors with the keyboard (bug 1854340) #17062

merged 1 commit into from
Oct 4, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from a team as a code owner October 3, 2023 13:08
@calixteman
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5ba5209cdbdf5ae/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5ba5209cdbdf5ae/output.txt

Total script time: 1.42 mins

Published

flodolo
flodolo approved these changes Oct 3, 2023
View reviewed changes
l10n/en-US/viewer.properties Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Oct 3, 2023 •
edited
Loading

One quick observation is that it doesn't seem possible to undo (with Ctrl+Z) the resizing done via the keyboard without moving focus away from the resizer elements first, and it's not clear to me if this is intentional behaviour or not?

Edit: This seems to apply to e.g. removing the editor (with Delete) as well.

Snuffleupagus
Snuffleupagus reviewed Oct 3, 2023
View reviewed changes
src/display/editor/editor.js Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

One quick observation is that it doesn't seem possible to undo (with Ctrl+Z) the resizing done via the keyboard without moving focus away from the resizer elements first, and it's not clear to me if this is intentional behaviour or not?

Edit: This seems to apply to e.g. removing the editor (with Delete) as well.

Yes it's on purpose: when we're entering in resize-with-keyboard mode we can just resize.
The a11y team checked how resizers can be controlled with the keyboard in other softwares and didn't find anything.
So we're more or less experimenting something here, hence the current behavior could be changed in the future.

Snuffleupagus
Snuffleupagus approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4f20b9e0be73463/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a7fc7b3c7d53c4b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4f20b9e0be73463/output.txt

Total script time: 5.62 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a7fc7b3c7d53c4b/output.txt

Total script time: 17.46 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 40d6b0e into mozilla:master Oct 4, 2023
@calixteman calixteman deleted the resize_keyboard branch October 4, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flodolo flodolo flodolo approved these changes

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @flodolo