Try to make the Preferences/AppOptions initialization slightly more efficient
#17130
Conversation
Snuffleupagus
force-pushed
the
AppOption-move-init
branch
from
b15af61 to
07b5bcb
Compare
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c68a242a4adc167/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6bd75456d2d46a9/output.txt |
Snuffleupagus
force-pushed
the
AppOption-move-init
branch
from
07b5bcb to
26a8956
Compare
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c68a242a4adc167/output.txt Total script time: 10.54 mins
Image differences available at: http://54.241.84.105:8877/c68a242a4adc167/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6bd75456d2d46a9/output.txt Total script time: 19.74 mins
Image differences available at: http://54.193.163.58:8877/6bd75456d2d46a9/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
AppOption-move-init
branch
from
26a8956 to
ef0f35c
Compare
…re efficient *Please note:* This patch contains a couple of micro-optimizations, hence I understand if it's deemed unnecessary. Move the `AppOptions` initialization into the `Preferences` constructor, since that allows us to remove a couple of function calls, a bit of asynchronicity and one loop that's currently happening in the early stages of the default viewer initialization. Finally, move the `Preferences` initialization to occur a *tiny* bit earlier since that cannot hurt given that the entire viewer initialization depends on it being available.
Snuffleupagus
force-pushed
the
AppOption-move-init
branch
from
ef0f35c to
5ddc949
Compare
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9ee8f526e9dc55a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d21258d02c5099c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9ee8f526e9dc55a/output.txt Total script time: 10.54 mins
Image differences available at: http://54.241.84.105:8877/9ee8f526e9dc55a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d21258d02c5099c/output.txt Total script time: 20.09 mins
Image differences available at: http://54.193.163.58:8877/d21258d02c5099c/reftest-analyzer.html#web=eq.log |
Please note: This patch contains a couple of micro-optimizations, hence I understand if it's deemed unnecessary.
Move the
AppOptionsinitialization into thePreferencesconstructor, since that allows us to remove a couple of function calls, a bit of asynchronicity and one loop that's currently happening in the early stages of the default viewer initialization.Finally, move the
Preferencesinitialization to occur a tiny bit earlier since that cannot hurt given that the entire viewer initialization depends on it being available.