-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set a type for the Blob
used in createCDNWrapper
(issue 17259)
#17265
Set a type for the Blob
used in createCDNWrapper
(issue 17259)
#17265
Conversation
Hopefully this is enough to address the problem of initializing the Worker in Chromium-based browsers. Locally I've tried to *force* use of `createCDNWrapper` in development mode, by commenting out the `isSameOrigin` checks, and worker-loading fails against `master` and works with this patch.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/facc775a7afaf17/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/facc775a7afaf17/output.txt Total script time: 1.40 mins Published |
/botio xfatest |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/007a88646145100/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0bb56e1b2432b7d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/0bb56e1b2432b7d/output.txt Total script time: 11.15 mins
Image differences available at: http://54.241.84.105:8877/0bb56e1b2432b7d/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/007a88646145100/output.txt Total script time: 18.90 mins
Image differences available at: http://54.193.163.58:8877/007a88646145100/reftest-analyzer.html#web=eq.log |
Looks good! |
Testing https://mozilla.github.io/pdf.js/examples/#interactive-examples now, after this has landed, it seems that worker-loading is now functioning as expected/intended in both Mozilla Firefox and Google Chrome. |
Hopefully this is enough to address the problem of initializing the Worker in Chromium-based browsers.
Locally I've tried to force use of
createCDNWrapper
in development mode, by commenting out theisSameOrigin
checks, and worker-loading fails againstmaster
and works with this patch.