Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a type for the Blob used in createCDNWrapper (issue 17259) #17265

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

Hopefully this is enough to address the problem of initializing the Worker in Chromium-based browsers.
Locally I've tried to force use of createCDNWrapper in development mode, by commenting out the isSameOrigin checks, and worker-loading fails against master and works with this patch.

Hopefully this is enough to address the problem of initializing the Worker in Chromium-based browsers.
Locally I've tried to *force* use of `createCDNWrapper` in development mode, by commenting out the `isSameOrigin` checks, and worker-loading fails against `master` and works with this patch.
@Snuffleupagus Snuffleupagus linked an issue Nov 12, 2023 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/facc775a7afaf17/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/facc775a7afaf17/output.txt

Total script time: 1.40 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/007a88646145100/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0bb56e1b2432b7d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/0bb56e1b2432b7d/output.txt

Total script time: 11.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/0bb56e1b2432b7d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/007a88646145100/output.txt

Total script time: 18.90 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 1

Image differences available at: http://54.193.163.58:8877/007a88646145100/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit 37a8311 into mozilla:master Nov 12, 2023
5 checks passed
@timvandermeij
Copy link
Contributor

Looks good!

@timvandermeij timvandermeij removed the request for review from calixteman November 12, 2023 11:58
@Snuffleupagus Snuffleupagus deleted the createCDNWrapper-blob-type branch November 12, 2023 12:19
@Snuffleupagus
Copy link
Collaborator Author

Testing https://mozilla.github.io/pdf.js/examples/#interactive-examples now, after this has landed, it seems that worker-loading is now functioning as expected/intended in both Mozilla Firefox and Google Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console error: Failed to load module script
3 participants