Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Init the default highlight color before creating the first editor instance #17481

Merged
merged 1 commit into from
Jan 5, 2024
Merged

[Editor] Init the default highlight color before creating the first editor instance #17481

merged 1 commit into from
Jan 5, 2024

Conversation

calixteman
Copy link
Contributor

We want to be able to draw an highlight with the default color but without having an instance of the HighlightEditor.

Snuffleupagus
Snuffleupagus approved these changes Jan 5, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for this?

r=me, thank you!

@calixteman calixteman force-pushed the editor_default_init branch from 9639011 to 2fb8f08 Compare January 5, 2024 14:35
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/645f5decefe2c99/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b664d2e3a54c82f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/645f5decefe2c99/output.txt

Total script time: 5.85 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/b664d2e3a54c82f/output.txt

Total script time: 17.01 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus requested changes Jan 5, 2024
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the editor_default_init branch from 2fb8f08 to 6c5b738 Compare January 5, 2024 15:42
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/f4e9ea69cb10f42/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f655f8b29845e61/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/f4e9ea69cb10f42/output.txt

Total script time: 5.72 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Jan 5, 2024
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f655f8b29845e61/output.txt

Total script time: 19.15 mins

  • Integration Tests: Passed

@calixteman
[Editor] Init the default highlight color before creating the first e…
17e1519 
…ditor instance

We want to be able to draw an highlight with the default color but without having an
instance of the HighlightEditor.
@calixteman calixteman force-pushed the editor_default_init branch from 6c5b738 to 17e1519 Compare January 5, 2024 16:53
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9773de507ed46a3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bdd1306b94ca4f2/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9773de507ed46a3/output.txt

Total script time: 5.88 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/bdd1306b94ca4f2/output.txt

Total script time: 16.08 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 6c5e237 into mozilla:master Jan 5, 2024
9 checks passed
@calixteman calixteman deleted the editor_default_init branch January 5, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus