-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistently remove the "visibilitychange" listener in PDFViewer
(PR 14388 follow-up)
#17508
Conversation
…R 14388 follow-up) By always removing the "visibilitychange" listener in the `PDFViewer.#onePageRenderedOrForceFetch`-method we can (ever so slightly) reduce duplication in the code.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f838fd31396a6f1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f838fd31396a6f1/output.txt Total script time: 1.48 mins Published |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/903ba7df511d8d9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/f72ed9baff81a46/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/903ba7df511d8d9/output.txt Total script time: 5.91 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/f72ed9baff81a46/output.txt Total script time: 17.97 mins
|
Thank you for simplifying this! |
By always removing the "visibilitychange" listener in the
PDFViewer.#onePageRenderedOrForceFetch
-method we can (ever so slightly) reduce duplication in the code.