Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that EvaluatorPreprocessor.opMap has a null-prototype (issue 17554) #17556

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Ensure that EvaluatorPreprocessor.opMap has a null-prototype (issue 17554) #17556

merged 1 commit into from
Jan 21, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This accidentally regressed in PR #16956, sorry about that!

@Snuffleupagus
Ensure that EvaluatorPreprocessor.opMap has a null-prototype (issue…
d7e41d4 
… 17554)

This accidentally regressed in PR 16956, sorry about that!
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0408dcd33350643/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0408dcd33350643/output.txt

Total script time: 1.43 mins

Published

calixteman
calixteman approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

timvandermeij
timvandermeij approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me as well, with passing tests. Thank you!

@timvandermeij
Copy link
Contributor

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d80b6fe3f236f07/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1e486f76c72faad/output.txt

@timvandermeij timvandermeij linked an issue Jan 21, 2024 that may be closed by this pull request
Javascript object default properties like toString are considered "valid" PDF operators #17554
Closed
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1e486f76c72faad/output.txt

Total script time: 24.72 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/1e486f76c72faad/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d80b6fe3f236f07/output.txt

Total script time: 34.71 mins

  • Unit tests: FAILED
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 21
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/d80b6fe3f236f07/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-windows unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/0f2bf2a1ee06323/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/0f2bf2a1ee06323/output.txt

Total script time: 8.97 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit 49b2d9b into mozilla:master Jan 21, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17554 branch January 21, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Javascript object default properties like toString are considered "valid" PDF operators
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman