[Editor] Remove the outline which is inside the free highlight shape #17586
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fcac16daa84f76c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fcac16daa84f76c/output.txt Total script time: 1.24 mins Published |
When an highlight is self-intersecting, the outline was drawn inside. In order to remove it, we use a svg mask to exclude the shape inside when drawing the outlines. That leads to change the outline 1px,white-2px,blue-1px,white to a 2px,white-2px,blue: the part of the stroke which is inside the shape is removed because of the mask.
calixteman
force-pushed
the
editor_freehighlight_outline_inside
branch
from
e495206 to
b88c6f9
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9d8b8f9d35452cc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/9d8b8f9d35452cc/output.txt Total script time: 1.19 mins Published |
|
It seems that, depending on the zoom-level, the editor-toolbar can obscure part of the outline for FreeHighlight. While this may perhaps be difficult to address generally (depending on the FreeHighlight shape), it doesn't seem to happen for any other type of editor.
|
It's unrelated to this patch and I'll fix the issue in an other one. |
|
@Snuffleupagus see #17602 for the issue you just mentioned. |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/84e925ef93a1929/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0cf79f4fddaff1e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0cf79f4fddaff1e/output.txt Total script time: 6.31 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/84e925ef93a1929/output.txt Total script time: 15.84 mins
|
When an highlight is self-intersecting, the outline was drawn inside. In order to remove it, we use a svg mask to exclude the shape inside when drawing the outlines.
That leads to change the outline 1px,white-2px,blue-1px,white to a 2px,white-2px,blue: the part of the stroke which is inside the shape is removed because of the mask.