Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the ExternalServices-instance lazily in the viewer (PR 17588 follow-up) #17604

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Initialize the ExternalServices-instance lazily in the viewer (PR 17588 follow-up) #17604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion web/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,6 @@ const PDFViewerApplication = {
url: "",
baseUrl: "",
_downloadUrl: "",
externalServices: new ExternalServices(),
_boundEvents: Object.create(null),
documentInfo: null,
metadata: null,
Expand Down Expand Up @@ -676,6 +675,10 @@ const PDFViewerApplication = {
}
},

get externalServices() {
return shadow(this, "externalServices", new ExternalServices());
},

get initialized() {
return this._initializedCapability.settled;
},
Expand Down