Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for require statements from the build system #17634

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

This part of the (modern) preprocessor is now dead code, since we no longer use require statements anywhere in the main code-base.

Note that as part of the changes leading up to PDF.js version 4 we removed all[1] the remaining require statements, and we also have an ESLint rule to ensure that no new ones are accidentally added.


[1] With two small exceptions, in benchmarking-code and in the Webpack-example.

This part of the (modern) preprocessor is now dead code, since we no longer use `require` statements anywhere in the main code-base.

Note that as part of the changes leading up to PDF.js version `4` we removed all[1] the remaining `require` statements, and we also have an ESLint rule to ensure that no new ones are accidentally added.

---
[1] With two small exceptions, in benchmarking-code and in the Webpack-example.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cd1f8b0cd7e0963/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/cd1f8b0cd7e0963/output.txt

Total script time: 1.27 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fb5eb82a0d8acb6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2519afcf05e2544/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/fb5eb82a0d8acb6/output.txt

Total script time: 25.01 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 22
  different first/second rendering: 3

Image differences available at: http://54.241.84.105:8877/fb5eb82a0d8acb6/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/2519afcf05e2544/output.txt

Total script time: 30.55 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5

Image differences available at: http://54.193.163.58:8877/2519afcf05e2544/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 0d5183a into mozilla:master Feb 8, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-preprocessor-require branch February 8, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants