-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for require
statements from the build system
#17634
Remove support for require
statements from the build system
#17634
Conversation
This part of the (modern) preprocessor is now dead code, since we no longer use `require` statements anywhere in the main code-base. Note that as part of the changes leading up to PDF.js version `4` we removed all[1] the remaining `require` statements, and we also have an ESLint rule to ensure that no new ones are accidentally added. --- [1] With two small exceptions, in benchmarking-code and in the Webpack-example.
8740d2a
to
6a78cf0
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cd1f8b0cd7e0963/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cd1f8b0cd7e0963/output.txt Total script time: 1.27 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/fb5eb82a0d8acb6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2519afcf05e2544/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/fb5eb82a0d8acb6/output.txt Total script time: 25.01 mins
Image differences available at: http://54.241.84.105:8877/fb5eb82a0d8acb6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2519afcf05e2544/output.txt Total script time: 30.55 mins
Image differences available at: http://54.193.163.58:8877/2519afcf05e2544/reftest-analyzer.html#web=eq.log |
This part of the (modern) preprocessor is now dead code, since we no longer use
require
statements anywhere in the main code-base.Note that as part of the changes leading up to PDF.js version
4
we removed all[1] the remainingrequire
statements, and we also have an ESLint rule to ensure that no new ones are accidentally added.[1] With two small exceptions, in benchmarking-code and in the Webpack-example.