Remove empty, top-level, nodes in the Babel plugin #17647
Conversation
Looking at the *built* files you'll notice some lines containing nothing more than a semicolon. This is the result of (mostly top-level) `if`-statements, which include `PDFJSDev`-checks, that evalute to `false` during Babel parsing. This has always annoyed me a bit, and looking at Babel plugin it seems that we can fix this simply by *removing* the relevant nodes.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/acd47838a20be39/output.txt |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/acd47838a20be39/output.txt Total script time: 1.21 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/424c37e1af13623/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6ab443584d36817/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/424c37e1af13623/output.txt Total script time: 24.82 mins
Image differences available at: http://54.241.84.105:8877/424c37e1af13623/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6ab443584d36817/output.txt Total script time: 39.19 mins
Image differences available at: http://54.193.163.58:8877/6ab443584d36817/reftest-analyzer.html#web=eq.log |
|
Hey don't feel blocked on me in any way, but just fyi I plan to review these Babel-related PRs by Monday. |
There was a problem hiding this comment.
Looks good to me, but let's await @nicolo-ribaudo's review as well before merging this. Thanks!
Looking at the built files you'll notice some lines containing nothing more than a semicolon. This is the result of (mostly top-level)
if-statements, which includePDFJSDev-checks, that evalute tofalseduring Babel parsing.This has always annoyed me a bit, and looking at Babel plugin it seems that we can fix this simply by removing the relevant nodes.