Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Avoid calling setTimeout when editing an existing freetext #17903

Merged
merged 1 commit into from
Apr 9, 2024
Merged

[Editor] Avoid calling setTimeout when editing an existing freetext #17903

merged 1 commit into from
Apr 9, 2024

Conversation

calixteman
Copy link
Contributor

The code was added in order to guess if an editor has been moved but it's simpler to just set a variable when it's dragged or moved with the keyboard. This way we remove a bit of asynchronicity.

@calixteman calixteman requested a review from Snuffleupagus April 8, 2024 13:05
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9c2faf45d17677a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/78db36356ff5481/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9c2faf45d17677a/output.txt

Total script time: 7.42 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/78db36356ff5481/output.txt

Total script time: 22.37 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes Apr 8, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with comments addressed.

src/display/editor/editor.js Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman
[Editor] Avoid calling setTimeout when editing an existing freetext
3b93fde 
The code was added in order to guess if an editor has been moved but
it's simpler to just set a variable when it's dragged or moved with
the keyboard. This way we remove a bit of asynchronicity.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5de61dead9fe2b1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/93499fd6b9e77cb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/93499fd6b9e77cb/output.txt

Total script time: 7.43 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/5de61dead9fe2b1/output.txt

Total script time: 23.17 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit a208d6b into mozilla:master Apr 9, 2024
9 checks passed
@calixteman calixteman deleted the moved_freetext branch April 9, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus