Remove waitForTimeout usage from the helper functions
#17966
Conversation
We should wait until the input field's value is actually empty instead of waiting for a fixed time (which could lead to intermittent failures).
… function The timeout was introduced in commit 402e3fe with equal timeouts around the helper function call. In commit 55e5af2 the timeouts around the helper function call have been removed, and it looks like the helper function itself was not updated purely due to an oversight. The operations here should not require any timeouts because the promises only resolve once the action is completed, which also explains why removing the timeouts surrounding the helper function calls went without any problems. It should therefore be safe to remove this timeout too.
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a9bebd6e2a1420e/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7582b2f7a2b1fbc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/7582b2f7a2b1fbc/output.txt Total script time: 13.91 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/a9bebd6e2a1420e/output.txt Total script time: 17.49 mins
|
|
(The Linux failure above is unrelated to this patch because it doesn't use any of the touched helper functions, and is therefore one of the remaining intermittents to be fixed in a later scope.) /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b7f43c23706efa5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/be9f6784595fcf8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b7f43c23706efa5/output.txt Total script time: 13.52 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/be9f6784595fcf8/output.txt Total script time: 17.71 mins
|
The commit messages contain more details about the individual changes.
Fixes a part of #17656.