Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signal-support in the EventBus, and utilize it in the viewer (PR 17964 follow-up) #17967

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Add signal-support in the EventBus, and utilize it in the viewer (PR 17964 follow-up) #17967

merged 4 commits into from
Apr 23, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This mimics the signal option that's available for addEventListener, see MDN.

calixteman
calixteman reviewed Apr 18, 2024
View reviewed changes
web/event_utils.js Outdated Show resolved Hide resolved
calixteman
calixteman reviewed Apr 18, 2024
View reviewed changes
web/event_utils.js Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus force-pushed the eventBus-signal branch 3 times, most recently from 24da601 to a7c0716 Compare April 20, 2024 09:43
@Snuffleupagus
Copy link
Collaborator Author

/botio xfatest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/372f754d4fb8556/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/94eb888a1337835/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/94eb888a1337835/output.txt

Total script time: 6.51 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://54.193.163.58:8877/94eb888a1337835/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/372f754d4fb8556/output.txt

Total script time: 12.37 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/372f754d4fb8556/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus marked this pull request as ready for review April 20, 2024 10:28
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/07a8becbbf9a8fa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c4069fc76dbae61/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/07a8becbbf9a8fa/output.txt

Total script time: 7.44 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c4069fc76dbae61/output.txt

Total script time: 18.41 mins

  • Integration Tests: FAILED

timvandermeij
timvandermeij approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; nice work!

@timvandermeij timvandermeij merged commit bda98b9 into mozilla:master Apr 23, 2024
7 checks passed
@Snuffleupagus Snuffleupagus deleted the eventBus-signal branch April 24, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman left review comments

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman