Slightly re-factor how the viewer initializes debug-only functionality #18061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a7d3fa144c4d0e7/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a7d3fa144c4d0e7/output.txt Total script time: 1.15 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/68ea8845b0e5829/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/68ea8845b0e5829/output.txt Total script time: 27.54 mins
Image differences available at: http://54.241.84.105:8877/68ea8845b0e5829/reftest-analyzer.html#web=eq.log |
This avoids having to add a couple of event listeners in the viewer, when debugging is enabled, and is consistent with the existing handling of `FontInspector` and `StepperManager` in the API.
…p.js` Given that this is a debug-only, and fairly short, function we can just inline the code.
…arams` Given that this is a debug-only function we don't need to define it "globally" in the `web/app.js` file.
Snuffleupagus
force-pushed
the
api-report-Stats
branch
from
1eccf31 to
5fbc5ba
Compare
timvandermeij
approved these changes
May 13, 2024
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional information.