Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Fix the CSS properties of the canvas when it's used in a stampEditor (bug 1895909) #18080

Merged
merged 1 commit into from
May 14, 2024
Merged

[Editor] Fix the CSS properties of the canvas when it's used in a stampEditor (bug 1895909) #18080

merged 1 commit into from
May 14, 2024

Conversation

calixteman
Copy link
Contributor

And move the page canvas properties under canvasWrapper in order to avoid future regressions.

@calixteman calixteman requested a review from Snuffleupagus May 13, 2024 14:18
@Snuffleupagus

This comment was marked as resolved.

Sign in to view
@calixteman
[Editor] Fix the CSS properties of the canvas when it's used in a sta…
093bdfd 
…mpEditor (bug 1895909)

And move the page canvas properties under canvasWrapper in order to avoid future regressions.
@calixteman
Copy link
Contributor Author

I added back the display: block for the page canvas in order to avoid any confusion and @nicolo-ribaudo can make a follow-up patch to fix the zoom stuff.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5df18a7dd05d244/output.txt

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b62946faa0537e3/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/5df18a7dd05d244/output.txt

Total script time: 7.15 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a0d1ff7736f157d/output.txt

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7b4c15ab863eb7b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7b4c15ab863eb7b/output.txt

Total script time: 8.72 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a002b21096dd8be/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a002b21096dd8be/output.txt

Total script time: 6.99 mins

  • Integration Tests: FAILED

Snuffleupagus
Snuffleupagus approved these changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing Windows tests; thank you!

@timvandermeij
Copy link
Contributor

/botio-windows integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 1

Live output at: http://54.193.163.58:8877/83e10fa2eee01db/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/83e10fa2eee01db/output.txt

Total script time: 19.50 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d2ac82699b49112/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d2ac82699b49112/output.txt

Total script time: 1.15 mins

Published

@timvandermeij timvandermeij merged commit ac7b86d into mozilla:master May 14, 2024
7 checks passed
@timvandermeij
Copy link
Contributor

Thank you for improving the CSS here, and adding more tests to avoid future regressions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @Snuffleupagus @moz-tools-bot @timvandermeij