Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support corrupt PDF documents that contain "endsteam" commands (issue 18122) #18125

Merged
merged 1 commit into from
May 21, 2024
Merged

Support corrupt PDF documents that contain "endsteam" commands (issue 18122) #18125

merged 1 commit into from
May 21, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This patch also re-factors the findStreamLength-helper to avoid even more code duplication.

@Snuffleupagus Snuffleupagus linked an issue May 21, 2024 that may be closed by this pull request
PDF not displaying in viewer. #18122
Closed
@Snuffleupagus Snuffleupagus marked this pull request as draft May 21, 2024 11:27
@Snuffleupagus
Support corrupt PDF documents that contain "endsteam" commands (issue…
57014d0 
… 18122)

This patch also re-factors the findStreamLength-helper to avoid even more code duplication.
@mozilla mozilla deleted a comment from moz-tools-bot May 21, 2024
@mozilla mozilla deleted a comment from moz-tools-bot May 21, 2024
@mozilla mozilla deleted a comment from moz-tools-bot May 21, 2024
@mozilla mozilla deleted a comment from moz-tools-bot May 21, 2024
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a387d9520446e2a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7bc2e6f2780cf65/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a387d9520446e2a/output.txt

Total script time: 27.67 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 15
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/a387d9520446e2a/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7bc2e6f2780cf65/output.txt

Total script time: 42.57 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/7bc2e6f2780cf65/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus marked this pull request as ready for review May 21, 2024 12:27
calixteman
calixteman approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit dce9c6d into mozilla:master May 21, 2024
9 checks passed
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3e993ac4f1d5a08/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/d08c63272512c25/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/3e993ac4f1d5a08/output.txt

Total script time: 20.03 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/d08c63272512c25/output.txt

Total script time: 25.06 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-18122 branch May 21, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core corrupted-pdf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF not displaying in viewer.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman