Add test for drawing delay with CSS-only zoom #18129
Conversation
|
Ok I think I can remove the |
nicolo-ribaudo
force-pushed
the
test-css-only-zoom
branch
2 times, most recently
from
7d4e7ed to
247709b
Compare
nicolo-ribaudo
force-pushed
the
test-css-only-zoom
branch
from
247709b to
1590b9e
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2d8dd9ddf79998b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2b85a9305b92866/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2d8dd9ddf79998b/output.txt Total script time: 7.35 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2b85a9305b92866/output.txt Total script time: 20.96 mins
|
|
Oh windows, I'll check what it is about. |
|
Isn't the problem that the first page can already be done rendering before the promise in the test is awaited because we already register the event handler in |
|
Maybe you could use a one-page pdf (for example empty.pdf) and check for pair of events pagerender/pagerendered. |
This commit adds a test for 0603d1a. Before the fix the `pagerendered` events would be fired just 2-3 milliseconds after the call to `increaseScale`/`decreaseScale`.
nicolo-ribaudo
force-pushed
the
test-css-only-zoom
branch
from
1590b9e to
53d8666
Compare
|
I noticed that |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4b4c22a25aed16c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/83ed3ac09b607fb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4b4c22a25aed16c/output.txt Total script time: 7.40 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/83ed3ac09b607fb/output.txt Total script time: 20.56 mins
|
|
Thank you for implementing this test! |
This commit adds a test for nicolo-ribaudo@0603d1a. Before the fix the
pagerenderedevents would be fired just 2-3 milliseconds after the call toincreaseScale/decreaseScale.I know that you are trying to move away fromwaitForTimeout, but I don't know how else to test this. I cannot simply wait for an event to be emitted, because I am testing that it is not emitted.