Don't recommend installing gulp-cli globally in the README and on the website
#18247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he website It's recommended to always install dependencies locally in the project folder because global dependencies can easily conflict with other projects and, because they are not managed by the project, diverge from versions defined in e.g. `package.json`. Previously we installed `gulp-cli` globally because at the time we lacked a convenient mechanism to use Gulp otherwise, but nowadays NPM provides the `npx` command for that purpose and recommends using it over global installations (see https://docs.npmjs.com/downloading-and-installing-packages-globally and PR mozilla#17489 that provided the ground work for using it). This commit therefore updates our README and website to no longer recommend installing `gulp-cli` globally but instead installing it locally from the already existing entries in `package.json` like all other dependencies we use. Not only does this remove the special-casing for `gulp-cli` which simplifies the installation procedure, it also ensures that the version ranges provided in `package.json` are respected. This change is similar to the change in commit 92de2b7. Fixes mozilla#18232. Fixes 98ef8a1.
timvandermeij
changed the title
gulp-cli globally in the READMEgulp-cli globally in the README and on the website
This was referenced Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's recommended to always install dependencies locally in the project folder because global dependencies can easily conflict with other projects and, because they are not managed by the project, diverge from versions defined in e.g.
package.json. Previously we installedgulp-cliglobally because at the time we lacked a convenient mechanism to use Gulp otherwise, but nowadays NPM provides thenpxcommand for that purpose and recommends using it over global installations (see https://docs.npmjs.com/downloading-and-installing-packages-globally and PR #17489 that provided the ground work for using it).This commit therefore updates our README and website to no longer recommend installing
gulp-cliglobally but instead installing it locally from the already existing entries inpackage.jsonlike all other dependencies we use. Not only does this remove the special-casing forgulp-cliwhich simplifies the installation procedure, it also ensures that the version ranges provided inpackage.jsonare respected.This change is similar to the change in commit 92de2b7.
Fixes #18232.
Fixes 98ef8a1.
This should be final patch in the
npxusage series, after the previous patches and updating all wiki pages. I somehow missed these occurrences before, but a new search didn't yield other occurrences anymore.