-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new formatted issue templates #18308
Conversation
e38d65a
to
ac98ffd
Compare
It seems like there is no way to have a yes/no required option whose default value is "unselected". I made the questions about "does this happen in the latest version" and "is this relevant to Firefox" default to no. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, thank you for doing this!
(Not landing this right away, simply to give other core contributors a chance to comment.)
I have requested a review from myself and @calixteman as additional sign-off on this. I'll try to have this reviewed tomorrow. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, and I think I agree with the comment from @marco-c that that's probably a better default value for most issues.
Default updated 👍 |
Now that all four approvals are in and the discussed feedback is addressed, let's do this. This should increase the quality of the bug reports, and if need be we can always tweak it further. Thank you for doing this! |
You can test this at https://github.com/nicolo-ribaudo/pdf.js/issues, and nicolo-ribaudo#1 is an example of the generated issue. It's unfortunate that all the small questions (such as "Operating system and its version") get their own header, but hopefully it will help with getting all the necessary info filled in properly.