-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api-minor] Remove Outliner
from the official API
#18441
Conversation
As far as I can tell `Outliner` is only exposed in the API because we need to access it when running some of the reference-tests, but is otherwise not used. Hence this seems like something that should be kept *internal* and thus only exposed in TESTING-builds.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bb35f7ef9ea6c39/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7bbf4ea8ea93408/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/bb35f7ef9ea6c39/output.txt Total script time: 30.00 mins
Image differences available at: http://54.241.84.105:8877/bb35f7ef9ea6c39/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7bbf4ea8ea93408/output.txt Total script time: 44.15 mins
Image differences available at: http://54.193.163.58:8877/7bbf4ea8ea93408/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Running makeref here, since I forgot to do that in PR #18417. /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3a356d718899882/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0fe9b53baad3788/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3a356d718899882/output.txt Total script time: 20.31 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0fe9b53baad3788/output.txt Total script time: 24.66 mins
|
As far as I can tell
Outliner
is only exposed in the API because we need to access it when running some of the reference-tests, but is otherwise not used.Hence this seems like something that should be kept internal and thus only exposed in TESTING-builds.