Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce some Map-usage in the AppOptions #18469

Merged
merged 3 commits into from
Jul 21, 2024
Merged

Introduce some Map-usage in the AppOptions #18469

merged 3 commits into from
Jul 21, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This simplifies both checking if an entry exists and iteration of the entries, and will help reduce the size/scope of PR #18465.

@Snuffleupagus
Change the compatibilityParams, used with AppOptions, to a Map
57ee035 
This is needed for upcoming changes, and simplifies both checking if an entry exists and iteration of the entries.
@Snuffleupagus
Change the userOptions, used with AppOptions, to a Map
7bd9206 
This is needed for upcoming changes, and simplifies both checking if an entry exists and iteration of the entries.
@Snuffleupagus
Add basic validation of the AppOptions BROWSER-kind
26989fd
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/901fc7987643309/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8bad670cb1bd9b9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/8bad670cb1bd9b9/output.txt

Total script time: 2.51 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/901fc7987643309/output.txt

Total script time: 7.94 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a7c2e39ca97dfd5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/745af196fef7785/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a7c2e39ca97dfd5/output.txt

Total script time: 8.57 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/745af196fef7785/output.txt

Total script time: 18.99 mins

  • Integration Tests: FAILED

@timvandermeij timvandermeij merged commit ebb3d27 into mozilla:master Jul 21, 2024
7 checks passed
@timvandermeij
Copy link
Contributor

Thank you for the patch!

@Snuffleupagus Snuffleupagus deleted the AppOptions-Maps branch July 21, 2024 13:23
@npanchal108 npanchal108 mentioned this pull request Aug 31, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman left review comments

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman