Add better support for AppOptions with multiple types (PR 18465 follow-up) #18480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b79e4a2147287dc/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b79e4a2147287dc/output.txt Total script time: 1.04 mins Published |
timvandermeij
approved these changes
Jul 22, 2024
…w-up) For options with varying types, see `useSystemFonts`, we're not sufficiently validating the type when setting a new value. This means that for an option that uses `OptionKind.UNDEF_ALLOWED` we'd allow *any* value, which is obviously not the intention. Hence we instead introduce a new and *optional* `type`-field that allows specifying exactly which types are valid when multiple ones are supported. *Note:* This obviously didn't occur to me until after PR 18465 landed, sorry about that!
Snuffleupagus
force-pushed
the
AppOptions-optional-type
branch
from
53ca512 to
b3ea789
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/44c9dc69565b48d/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/44c9dc69565b48d/output.txt Total script time: 1.06 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For options with varying types, see
useSystemFonts, we're not sufficiently validating the type when setting a new value. This means that for an option that usesOptionKind.UNDEF_ALLOWEDwe'd allow any value, which is obviously not the intention.Hence we instead introduce a new and optional
type-field that allows specifying exactly which types are valid when multiple ones are supported.Note: This obviously didn't occur to me until after PR #18465 landed, sorry about that!