Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Dispatch changes in prefs enableAltTextModelDownload and enableGuessAltText to the viewer (bug 1912024) #18573

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

calixteman
Copy link
Contributor

The user can change a setting in a tab and it must have an effect in the current viewer.

@calixteman
Copy link
Contributor Author

It can be tested in Firefox and I'll add a test here before the end of the week.

src/display/editor/stamp.js Show resolved Hide resolved
web/app.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
web/new_alt_text_manager.js Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator

It doesn't appear that an updated patch was pushed, so I don't know what to re-review here :-)

…bleGuessAltText to the viewer (bug 1912024)

The user can change a setting in a tab and it must have an effect in the current viewer.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comments fixed; thank you!

web/firefoxcom.js Show resolved Hide resolved
web/new_alt_text_manager.js Show resolved Hide resolved
web/new_alt_text_manager.js Show resolved Hide resolved
web/firefoxcom.js Show resolved Hide resolved
web/firefoxcom.js Show resolved Hide resolved
@calixteman calixteman merged commit fef2853 into mozilla:master Aug 7, 2024
8 checks passed
@calixteman calixteman deleted the cancel_ai_requests branch August 7, 2024 21:11
@calixteman
Copy link
Contributor Author

I forgot to push my last changes....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants