Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the enableHighlightEditor preference #18594

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Aug 10, 2024

This was enabled by default in Firefox 126, see bug 1867513, so hopefully we should be able to remove the option/preference now.

This was enabled by default in Firefox 126, see [bug 1867513](https://bugzilla.mozilla.org/show_bug.cgi?id=1867513), so hopefully we should be able to remove the option/preference now.
@Snuffleupagus Snuffleupagus force-pushed the rm-enableHighlightEditor-pref branch from bf4808b to b9f5e78 Compare August 10, 2024 14:00
@Snuffleupagus Snuffleupagus marked this pull request as ready for review August 12, 2024 17:35
@Snuffleupagus Snuffleupagus requested review from calixteman and removed request for calixteman August 12, 2024 17:44
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 17b2463 into mozilla:master Aug 13, 2024
6 checks passed
@Snuffleupagus Snuffleupagus deleted the rm-enableHighlightEditor-pref branch August 13, 2024 06:14
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 13, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411
aosmond pushed a commit to aosmond/gecko that referenced this pull request Sep 14, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Sep 16, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411

UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Sep 16, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411

UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Sep 16, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411

UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Sep 16, 2024
…e. r=pdfjs-reviewers,robwu

This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now.

Differential Revision: https://phabricator.services.mozilla.com/D221411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants