-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the enableHighlightEditor
preference
#18594
Merged
Snuffleupagus
merged 1 commit into
mozilla:master
from
Snuffleupagus:rm-enableHighlightEditor-pref
Aug 13, 2024
Merged
Remove the enableHighlightEditor
preference
#18594
Snuffleupagus
merged 1 commit into
mozilla:master
from
Snuffleupagus:rm-enableHighlightEditor-pref
Aug 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was enabled by default in Firefox 126, see [bug 1867513](https://bugzilla.mozilla.org/show_bug.cgi?id=1867513), so hopefully we should be able to remove the option/preference now.
Snuffleupagus
force-pushed
the
rm-enableHighlightEditor-pref
branch
from
August 10, 2024 14:00
bf4808b
to
b9f5e78
Compare
Snuffleupagus
requested review from
calixteman
and removed request for
calixteman
August 12, 2024 17:44
calixteman
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Sep 13, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Sep 14, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Sep 16, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411 UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Sep 16, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411 UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Sep 16, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411 UltraBlame original commit: c011b9b0def2c394bd90b1837935d502109db725
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Sep 16, 2024
…e. r=pdfjs-reviewers,robwu This preference was removed upstream in mozilla/pdf.js#18594, which was uplifted in https://bugzilla.mozilla.org/show_bug.cgi?id=1913880, hence the override should also be removed now. Differential Revision: https://phabricator.services.mozilla.com/D221411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was enabled by default in Firefox 126, see bug 1867513, so hopefully we should be able to remove the option/preference now.