Use Calibri and Lucida Console, when it's possible, in place of sans-serif and monospaced (bug 1922063) #18844
Conversation
|
Can we work-around this in |
|
Having this as a temporary work-around probably can't hurt, assuming it passes all tests of course, however since it's a browser regression it would be even better if it can be fixed there instead. As-is this would still affect older PDF.js versions once the regressing code-change reaches Firefox Release, and it'd likely lead to numerous (future) bug-reports about this problem here at GitHub. (Tentatively setting the |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d06001f09481c5c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6ea4fef84bd8802/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/d06001f09481c5c/output.txt Total script time: 31.73 mins
Image differences available at: http://54.241.84.105:8877/d06001f09481c5c/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6ea4fef84bd8802/output.txt Total script time: 47.44 mins
Image differences available at: http://54.193.163.58:8877/6ea4fef84bd8802/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a6f16a2b6f009d3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ac135e3951e421f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a6f16a2b6f009d3/output.txt Total script time: 31.60 mins
Image differences available at: http://54.241.84.105:8877/a6f16a2b6f009d3/reftest-analyzer.html#web=eq.log |
…serif and monospaced (bug 1922063) A recent change in Firefox induced too much difference between the text widths computed in using a Canvas and the ones computed by the text layout engine when rendering the text layer. Consequently, the text selection can be bad on Windows with some fonts like Arial or Consolas. This patch is a workaround to try to use in first place some fonts which don't have the problem.
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ac135e3951e421f/output.txt Total script time: 47.17 mins
Image differences available at: http://54.193.163.58:8877/ac135e3951e421f/reftest-analyzer.html#web=eq.log |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/9e3e1a84c4c88da/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/7af02adb706f02a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/9e3e1a84c4c88da/output.txt Total script time: 31.51 mins
Image differences available at: http://54.241.84.105:8877/9e3e1a84c4c88da/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/7af02adb706f02a/output.txt Total script time: 48.25 mins
Image differences available at: http://54.193.163.58:8877/7af02adb706f02a/reftest-analyzer.html#web=eq.log |
|
Thank you for the patch! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5ba50208d9af880/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6cc4680a28e0331/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5ba50208d9af880/output.txt Total script time: 20.47 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/6cc4680a28e0331/output.txt Total script time: 25.98 mins
|
A recent change in Firefox induced too much difference between the text widths computed in using a Canvas and the ones computed by the text layout engine when rendering the text layer. Consequently, the text selection can be bad on Windows with some fonts like Arial or Consolas. This patch is a workaround to try to use in first place some fonts which don't have the problem.