-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the temporary "visibilitychange" listener, in PDFViewer
, with AbortSignal.any()
#18873
Remove the temporary "visibilitychange" listener, in PDFViewer
, with AbortSignal.any()
#18873
Conversation
…h `AbortSignal.any()` This is similar to a lot of other code, where we've been replacing explicit `removeEventListener`-calls. Given the somewhat limited availability of `AbortSignal.any()`, see [MDN](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/any_static#browser_compatibility), this event listener will no longer be immediately removed in older browsers (however that should be fine).
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/8f01ff3c3544c81/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/8f01ff3c3544c81/output.txt Total script time: 1.01 mins Published |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/6928cfe00413082/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4e7572e9725ef23/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/6928cfe00413082/output.txt Total script time: 9.81 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/4e7572e9725ef23/output.txt Total script time: 19.98 mins
|
Looks good! |
This is similar to a lot of other code, where we've been replacing explicit
removeEventListener
-calls.Given the somewhat limited availability of
AbortSignal.any()
, see MDN, this event listener will no longer be immediately removed in older browsers (however that should be fine).