-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the pdkids
PDF document to the repository
#18902
Add the pdkids
PDF document to the repository
#18902
Conversation
Given that the sub-title of that document is "Public domain texts for young people." and that the images have clear sources at the end of the document, it should (hopefully) be OK to add it to the repository rather than relying on a linked test-case.
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3ca65c5c6101101/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6b751fea1d0c02e/output.txt |
@calixteman and I were talking about this, maybe we could store the PDFs in a separate repo. This would avoid slowing things down in the main pdf.js repo by having fewer binary files. |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3ca65c5c6101101/output.txt Total script time: 20.86 mins
Image differences available at: http://54.241.84.105:8877/3ca65c5c6101101/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6b751fea1d0c02e/output.txt Total script time: 30.45 mins
Image differences available at: http://54.193.163.58:8877/6b751fea1d0c02e/reftest-analyzer.html#web=eq.log |
A few observations/questions:
In any case, replacing a linked test-case as this PR does seems generally desirable regardless of any other (future) changes. |
Yes, it's something to consider for later, this PR looks good as it is. |
Given that this PR contains a small test-only change, I'll consider that as approval to just land this :-) |
Given that the sub-title of that document is "Public domain texts for young people." and that the images have clear sources at the end of the document, it should (hopefully) be OK to add it to the repository rather than relying on a linked test-case.