Use ImageDecoder in order to decode jpeg images (bug 1901223) #18910

calixteman · 2024-10-16T16:29:38Z

No description provided.

calixteman · 2024-10-16T16:50:38Z

/botio-linux preview

moz-tools-bot · 2024-10-16T16:50:40Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9df91481031c406/output.txt

moz-tools-bot · 2024-10-16T16:51:42Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9df91481031c406/output.txt

Total script time: 1.02 mins

Published

Viewer: http://54.241.84.105:8877/9df91481031c406/web/viewer.html
Viewer (legacy): http://54.241.84.105:8877/9df91481031c406/legacy/web/viewer.html

calixteman · 2024-10-22T17:43:36Z

/botio test

moz-tools-bot · 2024-10-22T17:43:39Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f4647d2af2a6fc2/output.txt

moz-tools-bot · 2024-10-22T17:43:39Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2466bf4356a4fe9/output.txt

moz-tools-bot · 2024-10-22T18:13:23Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/2466bf4356a4fe9/output.txt

Total script time: 29.72 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  errors: 253
  different ref/snapshot: 639
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/2466bf4356a4fe9/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-10-22T18:21:38Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f4647d2af2a6fc2/output.txt

Total script time: 37.97 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 706
  different ref/snapshot: 200

Image differences available at: http://54.193.163.58:8877/f4647d2af2a6fc2/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2024-10-22T18:27:51Z

Do you have benchmarking results that show (clear) improvements with this patch?

Unfortunately there's failures on both bots, since the logs contain:

TEST-UNEXPECTED-FAIL | test failed firefox has not responded in 120s

calixteman · 2024-10-22T18:40:20Z

2. Unfortunately there's failures on both bots, since the logs contain:

Oh I think I need to update Firefox to take into account the patch made to avoid this timeout.

calixteman · 2024-10-22T18:43:47Z

/botio test

moz-tools-bot · 2024-10-22T18:43:50Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c0d695913cfc321/output.txt

moz-tools-bot · 2024-10-22T18:43:50Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bf1cac04462dee5/output.txt

calixteman · 2024-10-22T19:00:44Z

Do you have benchmarking results that show (clear) improvements with this patch?

With the pdf in #18307, the time to render drops from ~120s to ~20s !
Of for pdf with a single jpeg image with normal dimensions, the win isn't so important because we've some overhead due the ImageDecoder stuff.
That said, I checked several normal pdfs and the improvement is between 20% and 100%, it depends of the image.

moz-tools-bot · 2024-10-22T19:16:52Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/bf1cac04462dee5/output.txt

Total script time: 33.02 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 17
  different ref/snapshot: 658
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/bf1cac04462dee5/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-10-22T19:34:57Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c0d695913cfc321/output.txt

Total script time: 51.11 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  different ref/snapshot: 323

Image differences available at: http://54.193.163.58:8877/c0d695913cfc321/reftest-analyzer.html#web=eq.log

Snuffleupagus · 2024-10-22T19:52:02Z

Before I review this, can you please confirm that you've looked through all ref-test results without finding any obvious regressions?

calixteman · 2024-10-22T20:23:06Z

Before I review this, can you please confirm that you've looked through all ref-test results without finding any obvious regressions?

Yep, I checked the results locally and on the bots and there's nothing obviously wrong.

Snuffleupagus

r=me, with a few minor (stylistic) comments; thank you.

src/core/image.js

src/core/jpeg_stream.js

src/core/jpg.js

calixteman · 2024-10-23T08:43:09Z

/botio test

moz-tools-bot · 2024-10-23T08:43:13Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e3fb1cc3dcd0aef/output.txt

moz-tools-bot · 2024-10-23T08:43:13Z

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bb47fa20df17688/output.txt

moz-tools-bot · 2024-10-23T09:15:18Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/e3fb1cc3dcd0aef/output.txt

Total script time: 32.07 mins

Unit tests: Passed
Integration Tests: Passed
Regression tests: FAILED

  errors: 17
  different ref/snapshot: 657
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/e3fb1cc3dcd0aef/reftest-analyzer.html#web=eq.log

moz-tools-bot · 2024-10-23T09:35:10Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bb47fa20df17688/output.txt

Total script time: 51.93 mins

Unit tests: Passed
Integration Tests: FAILED
Regression tests: FAILED

  different ref/snapshot: 322

Image differences available at: http://54.193.163.58:8877/bb47fa20df17688/reftest-analyzer.html#web=eq.log

calixteman · 2024-10-23T11:54:14Z

/botio makeref

moz-tools-bot · 2024-10-23T11:54:17Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/66d880079831007/output.txt

moz-tools-bot · 2024-10-23T11:54:17Z

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f681a21eba32e28/output.txt

moz-tools-bot · 2024-10-23T12:15:38Z

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/66d880079831007/output.txt

Total script time: 21.33 mins

Make references: FAILED

calixteman · 2024-10-23T12:20:10Z

I missed the Chrome timeout issue on linux bot...

moz-tools-bot · 2024-10-23T12:23:21Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/f681a21eba32e28/output.txt

Total script time: 29.05 mins

Make references: Passed
Check references: Passed

Snuffleupagus · 2024-10-23T12:24:20Z

I missed the Chrome timeout issue on linux bot...

That shouldn't be related to this PR though, since it's been happening intermittently for maybe a week and is mentioned in #18928 (comment).

calixteman · 2024-10-23T12:26:40Z

The guilty pdf takes around 20s to render on Windows with Chrome so 2min seems to be a bit exaggerated: I'll have a look on it.

calixteman · 2024-10-23T12:26:52Z

/botio-linux makeref

moz-tools-bot · 2024-10-23T12:26:55Z

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/839003a42e6c9c8/output.txt

moz-tools-bot · 2024-10-23T12:47:27Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/839003a42e6c9c8/output.txt

Total script time: 20.53 mins

Make references: Passed
Check references: Passed

timvandermeij added core image-conversion image-jpeg labels Oct 20, 2024

calixteman force-pushed the image_decoder1 branch from 034e1f7 to c5362a1 Compare October 22, 2024 17:42

calixteman marked this pull request as ready for review October 22, 2024 17:43

calixteman requested a review from Snuffleupagus October 22, 2024 19:39

Snuffleupagus approved these changes Oct 22, 2024

View reviewed changes

src/core/image.js Outdated Show resolved Hide resolved

src/core/jpeg_stream.js Outdated Show resolved Hide resolved

src/core/jpg.js Outdated Show resolved Hide resolved

src/core/jpg.js Outdated Show resolved Hide resolved

src/core/jpg.js Outdated Show resolved Hide resolved

Use ImageDecoder in order to decode jpeg images (bug 1901223)

b6c4f0b

calixteman force-pushed the image_decoder1 branch from c5362a1 to b6c4f0b Compare October 23, 2024 08:42

Snuffleupagus linked an issue Oct 23, 2024 that may be closed by this pull request

Opening 24 MB PDF file with graphics takes very long and 100 % CPU usage #18307

Closed

calixteman merged commit 1ad0977 into mozilla:master Oct 23, 2024
10 checks passed

calixteman deleted the image_decoder1 branch October 23, 2024 13:02

Snuffleupagus linked an issue Oct 26, 2024 that may be closed by this pull request

[performance]: The putBinaryImageData function takes too long and blocks page interaction. #18088

Closed

Use ImageDecoder in order to decode jpeg images (bug 1901223) #18910

Use ImageDecoder in order to decode jpeg images (bug 1901223) #18910

Conversation

calixteman commented Oct 16, 2024

calixteman commented Oct 16, 2024

moz-tools-bot commented Oct 16, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 16, 2024

From: Bot.io (Linux m4)

Success

Published

calixteman commented Oct 22, 2024

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Windows)

Failed

Snuffleupagus commented Oct 22, 2024

calixteman commented Oct 22, 2024

calixteman commented Oct 22, 2024

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Linux m4)

Received

calixteman commented Oct 22, 2024

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Oct 22, 2024

From: Bot.io (Windows)

Failed

Snuffleupagus commented Oct 22, 2024

calixteman commented Oct 22, 2024

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Oct 23, 2024

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)

Failed

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Windows)

Failed

calixteman commented Oct 23, 2024

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Windows)

Received

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)

Failed

calixteman commented Oct 23, 2024

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Windows)

Success

Snuffleupagus commented Oct 23, 2024

calixteman commented Oct 23, 2024

calixteman commented Oct 23, 2024

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Oct 23, 2024

From: Bot.io (Linux m4)