Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace eslint-plugin-sort-exports by eslint-plugin-perfectionist #18929

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

timvandermeij
Copy link
Contributor

@timvandermeij timvandermeij commented Oct 20, 2024

The eslint-plugin-sort-exports plugin doesn't support ESLint 9 or has published plans to do so. The eslint-plugin-perfectionist does support ESLint 9 [1], seems more actively maintained [2, 3] and contains other rules that could be interesting later on [4]. Note that both plugins behave the same, except for two cases which are updated here.

[1] azat-io/eslint-plugin-perfectionist#154
[2] https://github.com/azat-io/eslint-plugin-perfectionist/commits/main
[3] https://www.npmjs.com/package/eslint-plugin-perfectionist?activeTab=versions
[4] https://perfectionist.dev/rules

Fixes a part of #17928 (and should remove the last blocker for the upgrade).

The `eslint-plugin-sort-exports` plugin doesn't support ESLint 9 or has
published plans to do so. The `eslint-plugin-perfectionist` does support
ESLint 9 [1], seems more actively maintained [2, 3] and contains other
rules that could be interesting later on [4]. Note that both plugins
behave the same, except for two cases which are updated here.

[1] azat-io/eslint-plugin-perfectionist#154
[2] https://github.com/azat-io/eslint-plugin-perfectionist/commits/main
[3] https://www.npmjs.com/package/eslint-plugin-perfectionist?activeTab=versions
[4] https://perfectionist.dev/rules
@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://54.241.84.105:8877/7cd6d99bcf37b71/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7cd6d99bcf37b71/output.txt

Total script time: 1.00 mins

Published

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you.

@timvandermeij timvandermeij merged commit b94ab46 into mozilla:master Oct 20, 2024
8 checks passed
@timvandermeij timvandermeij deleted the eslint-perfectionist branch October 20, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants