-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow StreamsSequenceStream
to skip sub-streams that are not actual Streams (issue 18973)
#18974
Conversation
… Streams (issue 18973) This extends PR 13796 to also handle the case where sub-streams contain invalid data, i.e. anything that isn't a Stream, however please note that in these cases there's no guarantee that we'll render the page "correctly". Note that Adobe Reader, i.e. the PDF reference implementation, cannot render the last page of the referenced PDF document.
1bbfed9
to
48a1858
Compare
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/347ee886be19013/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0943b2613487b69/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0943b2613487b69/output.txt Total script time: 2.45 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/347ee886be19013/output.txt Total script time: 7.25 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
/botio browsertest |
From: Bot.io (Linux m4)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/71a6c02ca4d3569/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_browsertest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9046c48a77f631c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/71a6c02ca4d3569/output.txt Total script time: 20.66 mins
Image differences available at: http://54.241.84.105:8877/71a6c02ca4d3569/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9046c48a77f631c/output.txt Total script time: 28.94 mins
Image differences available at: http://54.193.163.58:8877/9046c48a77f631c/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/84a6b5bbe647c7c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/67d2094301b9374/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/67d2094301b9374/output.txt Total script time: 20.63 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/84a6b5bbe647c7c/output.txt Total script time: 29.51 mins
|
This extends PR #13796 to also handle the case where sub-streams contain invalid data, i.e. anything that isn't a Stream, however please note that in these cases there's no guarantee that we'll render the page "correctly".
Note that Adobe Reader, i.e. the PDF reference implementation, cannot render the last page of the referenced PDF document.