Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't initialize L10n.#elements eagerly since it's unused in MOZCENTRAL builds #18979

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

It's not necessary to manually start translation in the Firefox PDF Viewer, and doing so would even cause problems there (see issue #17142).

…TRAL builds

It's not necessary to manually start translation in the Firefox PDF Viewer, and doing so would even cause problems there (see issue 17142).
@Snuffleupagus Snuffleupagus added viewer l10n Localization labels Oct 30, 2024
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/44d707167a3812d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d32a611b55cb05e/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/d32a611b55cb05e/output.txt

Total script time: 8.75 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/44d707167a3812d/output.txt

Total script time: 19.39 mins

  • Integration Tests: FAILED

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 3ed438a into mozilla:master Oct 31, 2024
8 checks passed
@Snuffleupagus Snuffleupagus deleted the L10n-#elements-lazy-init branch October 31, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n Localization viewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants