-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert the getPdfManager
function to be asynchronous
#19091
Convert the getPdfManager
function to be asynchronous
#19091
Conversation
This is fairly old code, and by making the function `async` we can handle initialization errors "automatically" without the need for try-catch statements.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ed8f62bc348bad1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/da9d84834284c68/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/da9d84834284c68/output.txt Total script time: 30.59 mins
Image differences available at: http://54.241.84.105:8877/da9d84834284c68/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ed8f62bc348bad1/output.txt Total script time: 46.08 mins
|
/botio-windows unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fe6f7a2181b67cc/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/fe6f7a2181b67cc/output.txt Total script time: 6.64 mins
|
Nice improvement! |
This is fairly old code, and by making the function
async
we can handle initialization errors "automatically" without the need for try-catch statements.