Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert the getPdfManager function to be asynchronous #19091

Merged
merged 1 commit into from
Nov 24, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

This is fairly old code, and by making the function async we can handle initialization errors "automatically" without the need for try-catch statements.

This is fairly old code, and by making the function `async` we can handle initialization errors "automatically" without the need for try-catch statements.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ed8f62bc348bad1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/da9d84834284c68/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/da9d84834284c68/output.txt

Total script time: 30.59 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 15
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/da9d84834284c68/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/ed8f62bc348bad1/output.txt

Total script time: 46.08 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fe6f7a2181b67cc/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/fe6f7a2181b67cc/output.txt

Total script time: 6.64 mins

  • Unit Tests: Passed

@timvandermeij timvandermeij merged commit d45a61b into mozilla:master Nov 24, 2024
9 checks passed
@timvandermeij
Copy link
Contributor

Nice improvement!

@Snuffleupagus Snuffleupagus deleted the getPdfManager-async branch November 24, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants