Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Disallow to have multiple pointers while dragging an editor #19109

Merged
merged 1 commit into from
Nov 27, 2024
Merged

[Editor] Disallow to have multiple pointers while dragging an editor #19109

merged 1 commit into from
Nov 27, 2024

Conversation

calixteman
Copy link
Contributor

It'll let the user dragging with two fingers.

@calixteman
Copy link
Contributor Author

Unfortunately the test isn't failing without the patch and the current version of Puppeteer we use, but with the last one (at least) it's fine.
/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a0d45c9097467f0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/27afcc9c47c3a9d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a0d45c9097467f0/output.txt

Total script time: 9.75 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/27afcc9c47c3a9d/output.txt

Total script time: 20.15 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/456e38e815e0073/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9279ad29564f79c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/456e38e815e0073/output.txt

Total script time: 8.80 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9279ad29564f79c/output.txt

Total script time: 20.57 mins

  • Integration Tests: Passed

Snuffleupagus
Snuffleupagus approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a few suggestions to reduce a little bit of duplication; thank you.

src/display/editor/editor.js Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
src/display/editor/editor.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the click_when_dragging branch 2 times, most recently from 6753a3f to 710d9a6 Compare November 27, 2024 17:49
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 2

Live output at: http://54.241.84.105:8877/b13b5e8d51c9dba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/6819abaeff0c713/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b13b5e8d51c9dba/output.txt

Total script time: 11.85 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6819abaeff0c713/output.txt

Total script time: 22.55 mins

  • Integration Tests: FAILED

@calixteman
[Editor] Disallow to have multiple pointers while dragging an editor
e695d04 
It'll let the user dragging with two fingers.
@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/3a24c1b4d66d932/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e8ee7fa2335aa8c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e8ee7fa2335aa8c/output.txt

Total script time: 8.81 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/3a24c1b4d66d932/output.txt

Total script time: 19.46 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit 22babd7 into mozilla:master Nov 27, 2024
9 checks passed
@calixteman calixteman deleted the click_when_dragging branch November 27, 2024 19:26
@Snuffleupagus Snuffleupagus mentioned this pull request Nov 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixteman @moz-tools-bot @Snuffleupagus