Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that a missing/invalid "Content-Range" header is handled in PDFNetworkStream (issue 19075) #19114

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Ensure that a missing/invalid "Content-Range" header is handled in PDFNetworkStream (issue 19075) #19114

merged 2 commits into from
Dec 6, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

In the event that the "Content-Range" header is missing/invalid, loading will now be aborted rather than hanging indefinitely.

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@Snuffleupagus Snuffleupagus linked an issue Nov 27, 2024 that may be closed by this pull request
PDF.js stuck without feedback when Content-Range header is missing #19075
Closed
@mozilla mozilla deleted a comment from moz-tools-bot Dec 1, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 1, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 1, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 1, 2024
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d10bfa9b6850d84/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1f743ff258c87ab/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d10bfa9b6850d84/output.txt

Total script time: 2.61 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/1f743ff258c87ab/output.txt

Total script time: 6.80 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus requested a review from Rob--W December 1, 2024 17:47
Rob--W
Rob--W requested changes Dec 2, 2024
View reviewed changes
src/display/network.js Outdated Show resolved Hide resolved
test/unit/network_spec.js Outdated Show resolved Hide resolved
@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/8cb9437d587ec58/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/44108eb8ff43b32/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/44108eb8ff43b32/output.txt

Total script time: 2.52 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/8cb9437d587ec58/output.txt

Total script time: 6.94 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus requested a review from Rob--W December 2, 2024 18:26
Rob--W
Rob--W approved these changes Dec 6, 2024
View reviewed changes
test/webserver.mjs Show resolved Hide resolved
@Snuffleupagus
Ensure that a missing/invalid "Content-Range" header is handled in `P…
2661d06 
…DFNetworkStream` (issue 19075)

In the event that the "Content-Range" header is missing/invalid, loading will now be aborted rather than hanging indefinitely.
@Snuffleupagus
Make the onError callback required in NetworkManager
eff8ede 
This helps ensure that loading errors are always handled correctly, and note that both `PDFNetworkStreamFullRequestReader` and `PDFNetworkStreamRangeRequestReader` already provided such a callback.
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@mozilla mozilla deleted a comment from moz-tools-bot Dec 6, 2024
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e79f19a48093145/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/acfda51ce3f7fd9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e79f19a48093145/output.txt

Total script time: 2.51 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/acfda51ce3f7fd9/output.txt

Total script time: 6.87 mins

  • Unit Tests: Passed

@Snuffleupagus
Copy link
Collaborator Author

/botio unittest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7d3655d00bc332f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_unittest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4954854b64557c8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/4954854b64557c8/output.txt

Total script time: 2.52 mins

  • Unit Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/7d3655d00bc332f/output.txt

Total script time: 6.59 mins

  • Unit Tests: Passed

@Snuffleupagus Snuffleupagus merged commit 60eba28 into mozilla:master Dec 6, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-19075 branch December 6, 2024 11:31
Snuffleupagus added a commit to Snuffleupagus/pdf.js that referenced this pull request Dec 10, 2024
@Snuffleupagus
Try to fix intermittent failure in `handle reading ranges with missin…
7f0e55c 
…g/invalid "Content-Range" header` unit-test (PR 19114 follow-up)

Implements mozilla#19114 (comment), which didn't seem necessary at the time since the unit-tests passed (many times) in PR 19114.
@Snuffleupagus Snuffleupagus mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rob--W Rob--W Rob--W approved these changes

Assignees
No one assigned
Labels
core test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDF.js stuck without feedback when Content-Range header is missing
3 participants
@Snuffleupagus @moz-tools-bot @Rob--W